Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEI_CERT_LCK01 updated #2266

Merged
merged 3 commits into from
Jun 19, 2023
Merged

SEI_CERT_LCK01 updated #2266

merged 3 commits into from
Jun 19, 2023

Conversation

katheg
Copy link
Contributor

@katheg katheg commented Nov 20, 2022

New function added to detector SynchronizationOnSharedBuiltinConstantto detect DL_SYNCHRONIZATION_ON_INTERNED_STRING

https://wiki.sei.cmu.edu/confluence/display/java/LCK01-J.+Do+not+synchronize+on+objects+that+may+be+reused


Make sure these boxes are checked before submitting your PR -- thank you!

  • Added an entry into CHANGELOG.md if you have changed SpotBugs code

@ThrawnCA
Copy link
Contributor

Is this something people actually do? It seems bizarre.

@hazendaz

This comment was marked as outdated.

@hazendaz
Copy link
Member

Sorry totally read this wrong first time through, approved and will merge.

@hazendaz hazendaz self-assigned this Jun 19, 2023
@hazendaz hazendaz merged commit d3645d8 into spotbugs:master Jun 19, 2023
4 checks passed
@hazendaz hazendaz added this to the SpotBugs 4.8.0 milestone Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants