NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE
false positive when code is formatted on different lines
#2874
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #782 calls such as
checkNotNull(get());
are correctly analyzed but when formatting on different lines they are not:Objects.requireNonNull
is correctly recognized since #2709 was mergedConcerning
javax.annotation.Nullable
its nullability is@Nonnull(when = When.UNKNOWN)
, my understanding is that this explains why it is ignored here. On the other end, the custom annotation from the sample is@Nonnull(when = When.MAYBE)
so it is considered and flagged accordingly