This repository has been archived by the owner on Mar 31, 2022. It is now read-only.
* Add arbitrary build param support #174
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any update on this PR? |
|
Merging this PR should solve #202 as well. |
steven-sheehy
suggested changes
Jul 31, 2018
| @@ -92,6 +92,9 @@ | |||
| @Parameter(property = "dockerfile.buildArgs") | |||
| private Map<String,String> buildArgs; | |||
|
|
|||
| @Parameter(property = "dockerfile.builParams") | |||
There was a problem hiding this comment.
Spelling is wrong. "dockerfile.buildParams"
DylanSchell
force-pushed
the
add-arbitrary-build-param-support
branch
from
bcd3100
to
21f2206
Compare
DylanSchell
force-pushed
the
add-arbitrary-build-param-support
branch
from
21f2206
to
a390ec0
Compare
|
fixed the typo |
|
Hi @DylanSchell, @steven-sheehy |
|
Any chance this can get the conflict fixed and merged? I am really needing this to set build arguments like network=host |
|
We use intermediate containers to save space. This option would help a lot for CI builds. I could use |
|
I could really do with this PR... I need to add some options to docker build command... |
|
Can't you just build the whole file from scratch?
…On Tue, Mar 22, 2022 at 4:19 AM Sergio Eduardo Dantas de Oliveira < ***@***.***> wrote:
I could really do with this PR... I need to add some options to docker
build command...
—
Reply to this email directly, view it on GitHub
<#174 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUTIGD6X7SSGDW3C2OBDWBLVBENZ5ANCNFSM4E7VRENA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some builds, we need shm-size support. by implementing arbitrary build parameter support, it should be possible to just configure
1000000000