Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relocation info to maven (if we think this is needed) #129

Open
klaraward opened this issue Feb 17, 2022 · 6 comments
Open

Add relocation info to maven (if we think this is needed) #129

klaraward opened this issue Feb 17, 2022 · 6 comments

Comments

@klaraward
Copy link
Contributor

See https://maven.apache.org/guides/mini/guide-relocation.html

@malaporte
Copy link
Contributor

I'm not sure if the steps highlighted in that doc are required? We do not need to republish the older versions to the new group ID, right? Can't you just publish a new one using Spotify's?

@klaraward
Copy link
Contributor Author

I'm not sure if the steps highlighted in that doc are required? We do not need to republish the older versions to the new group ID, right? Can't you just publish a new one using Spotify's?

Looking in to how this works.

@klaraward
Copy link
Contributor Author

I think we do something like this: https://stackoverflow.com/questions/24494974/how-do-i-deploy-a-relocation-pom-xml-to-sonatypes-oss-repository
Which would mean someone who can sign and deploy for the com.coveogroupId needs to do it (aka @malaporte)

@klaraward
Copy link
Contributor Author

klaraward commented Feb 18, 2022

Also the docs from the description say

[](https://maven.apache.org/guides/mini/guide-relocation.html#releasing-the-next-version)Releasing the next version
When the next release of foo is made, you should publish two Maven 2 POM files: first you should publish foo's POM with the new groupId org.bar.

Because data in the repository is not supposed to change, Maven doesn't download POM files that it has already downloaded. Therefore you will also need to publish a relocation POM file with the old groupId bar for the new version: this should be a minimal relocation POM (as described in step 4 above), but for the new version of foo.

For the release after that, you only need to publish a Maven POM with a groupId of org.bar, since users of the previous version have been informed of the changed groupId.

So from what I understand:

  1. Bump the version and publish a release with the com.spotify.fmt groupId (aka org.bar in the example above) (Someone with access to the spotify groupId and signing, aka @klaraward (me) should do that) - Change groupId and package to com.spotify.fmt #124 covers those changes
  2. Keep the same version and publish a relocation POM where the groupId is com.coveo (aka bar) and the relocation groupId is com.spotify.fmt (Someone with access to the coveo groupId and signing, aka @malaporte should do that) - Change to pom for this is in [Don't merge] Add relocation info from com.coveo to com.spotify.fmt #130

Does that sound reasonable?

@klaraward
Copy link
Contributor Author

It looks to me that this could be done any time after a new release with the new spotify groupId, so I wont consider the relocation fix blocking that release.

@malaporte
Copy link
Contributor

OK just tell me when the release is done on your side and I'll try to follow the steps mentioned.

@klaraward klaraward changed the title Add relocation info to maven Add relocation info to maven (if we think this is needed) Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants