Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Don't merge] Add relocation info from com.coveo to com.spotify.fmt #130

Closed
wants to merge 3 commits into from

Conversation

klaraward
Copy link
Contributor

@klaraward klaraward commented Feb 18, 2022

See also #129

What this would give is information similar to this one - https://mvnrepository.com/artifact/org.apache.commons/commons-io

Copy link
Contributor

@caesar-ralf caesar-ralf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you create this for example? I don't think we need. If we want to republish each old version with our group we need them to checkout each version tag and republish with the minimal pom that looks like

<project>
  <modelVersion>4.0.0</modelVersion>
  <groupId>com.coveo</groupId>
  <artifactId>fmt-maven-plugin</artifactId>
  <version>${VERSION_ALREADY_PUBLISHED}</version>
  <distributionManagement>
    <relocation>
      <groupId>com.spotify.fmt</groupId>
    </relocation>
  </distributionManagement>
</project>

right? I might be wrong

@klaraward
Copy link
Contributor Author

Did you create this for example? I don't think we need. If we want to republish each old version with our group we need them to checkout each version tag and republish with the minimal pom that looks like

<project>
  <modelVersion>4.0.0</modelVersion>
  <groupId>com.coveo</groupId>
  <artifactId>fmt-maven-plugin</artifactId>
  <version>${VERSION_ALREADY_PUBLISHED}</version>
  <distributionManagement>
    <relocation>
      <groupId>com.spotify.fmt</groupId>
    </relocation>
  </distributionManagement>
</project>

right? I might be wrong

I was thinking we would do this for one version, 2.14, and @malaporte could run deploy from this branch (once we change the version to 2.14 in it)

What I intended to do was to produce sort of the same small pom as above, but with the signing plugin as well. We could make pom in this PR even smaller.

@klaraward
Copy link
Contributor Author

Made the pom smaller

@klaraward klaraward changed the title Add relocation info from com.coveo to com.spotify.fmt [Don't merge] Add relocation info from com.coveo to com.spotify.fmt Feb 22, 2022
@caesar-ralf
Copy link
Contributor

closing old PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants