[scio-core](feature) Add readFiles and readFilesWithPath apis #5350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RustedBones
commented
Apr 30, 2024
Comment on lines
+1444
to
+1446
| desiredBundleSizeBytes: Long, | ||
| directoryTreatment: DirectoryTreatment, | ||
| compression: Compression |
There was a problem hiding this comment.
Cannot give default since we have overload.
kellen
reviewed
May 1, 2024
| * @param compression | ||
| * Reads files using the given [[org.apache.beam.sdk.io.Compression]]. | ||
| */ | ||
| def readFilesWithPath[A: Coder]( |
There was a problem hiding this comment.
It'd be nice to provide variants for this API for the various IO types to alleviate the user burden of knowing about the underlying beam api and needing to construct the various sources.
There was a problem hiding this comment.
Added to Text and Avro.
I think we should also add the readFiles variant for other file IOs.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5350 +/- ##
==========================================
- Coverage 62.69% 61.05% -1.64%
==========================================
Files 301 303 +2
Lines 10848 10901 +53
Branches 773 737 -36
==========================================
- Hits 6801 6656 -145
- Misses 4047 4245 +198 ☔ View full report in Codecov by Sentry. |
kellen
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new
readFilesapi based on splittableFileBasedSourceAdd new
readFilesWithPathpropagating source file path along with element emitted by the sourcerename
readFilestoreadTextFilesfor lines apiadd
readAvroGenericFilesandreadAvroSpecificFilesapis +WithPathapi variants