[scio-core](feature) Sample SCollection with max weight #5352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RustedBones
force-pushed
the
sample-weighted
branch
3 times, most recently
from
20fc05d
to
6baf89c
Compare
RustedBones
commented
May 2, 2024
scio-core/src/main/scala/com/spotify/scio/values/SCollection.scala
Outdated
Show resolved
Hide resolved
| val observer = new ElementByteSizeObserver { | ||
| override def reportElementSize(elementByteSize: Long): Unit = size += elementByteSize | ||
| } | ||
| bCoder.registerByteSizeObserver(e, observer) |
There was a problem hiding this comment.
this is better than CoderUtils.encodeToByteArray(beamCoder, v).length because it uses a new CountingOutputStream(ByteStreams.nullOutputStream())) behind the scene.
The code can be factorized with batchByteSized moving out of draft state
scio-core/src/main/scala/com/spotify/scio/values/SCollection.scala
Outdated
Show resolved
Hide resolved
RustedBones
commented
May 2, 2024
scio-core/src/main/scala/com/spotify/scio/values/SCollection.scala
Outdated
Show resolved
Hide resolved
RustedBones
commented
May 2, 2024
scio-core/src/main/scala/com/spotify/scio/values/SCollection.scala
Outdated
Show resolved
Hide resolved
RustedBones
force-pushed
the
sample-weighted
branch
from
5b00a85
to
e528d01
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5352 +/- ##
==========================================
+ Coverage 61.22% 61.30% +0.07%
==========================================
Files 302 303 +1
Lines 10846 10876 +30
Branches 761 780 +19
==========================================
+ Hits 6641 6667 +26
- Misses 4205 4209 +4 ☔ View full report in Codecov by Sentry. |
kellen
reviewed
May 2, 2024
scio-core/src/main/scala/com/spotify/scio/values/SCollection.scala
Outdated
Show resolved
Hide resolved
| val observer = new ElementByteSizeObserver { | ||
| override def reportElementSize(elementByteSize: Long): Unit = size += elementByteSize | ||
| } | ||
| bCoder.registerByteSizeObserver(e, observer) |
kellen
reviewed
May 2, 2024
scio-core/src/main/scala/com/spotify/scio/values/SCollection.scala
Outdated
Show resolved
Hide resolved
RustedBones
force-pushed
the
sample-weighted
branch
from
f493592
to
7479d50
Compare
RustedBones
force-pushed
the
sample-weighted
branch
from
7479d50
to
b3e6780
Compare
kellen
approved these changes
May 16, 2024
| def sample(sampleSize: Int): SCollection[Iterable[T]] = this.transform { | ||
| _.pApply(Sample.fixedSizeGlobally(sampleSize)).map(_.asScala) | ||
| } | ||
| // TODO move to implicit |
There was a problem hiding this comment.
Do you want to resolve this in this PR?
There was a problem hiding this comment.
This would be binary breaking. it is a reminder for later. maybe worth an issue with milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a sampling API with weighted limit and and byte size limit