Fix duplicated web scripts options #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrading `commander.js` to 5.x resulted in unknown options being parsed twice, breaking tasks in some scenarios. For more details: tj/commander.js#1138 Fixes spotify#341
pmowrer
commented
May 15, 2020
| @@ -200,7 +200,7 @@ describe('integration tests', () => { | |||
|
|
|||
| async function testScripts( | |||
| buildArgs: string[] = [], | |||
| lintArgs: string[] = [], | |||
| lintArgs: string[] = ['--ignore-path=.gitignore', '--format=checkstyle'], | |||
There was a problem hiding this comment.
Added reproduction from #341 as a failing test, though I guess it's a bit random to be testing with these specific options set. Perhaps better broken out as a separate test.
There was a problem hiding this comment.
I think this is good for now - we have a separate backlog task to break this IT up into something more manageable for all of the scripts.
fastfrwrd
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading
commander.jsto 5.x resulted in unknown options being parsed twice, breaking tasks in some scenarios.For more details: tj/commander.js#1138