fix(eslint-config-react): Add static-variables to react/sort-comp
#70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`eslint-plugin-react` was updated (jsx-eslint/eslint-plugin-react#2408) to support a new `static-variables` option to `react/sort-comp`. With this change, our linting started breaking. After some investigation, it turns out that `statics` seems to refer to some old `React.createClass` option, so static variables actually fell into the check for `static-methods`. Now that is fixed and `static-methods` only check for methods and `static-variables` only check for variables. So it doesn't seem like a breaking change, but we seem to have misused the options a bit. By only adding `static-variables` to our list we should still support older apps using `React.createClass` (if any), and everything will work again like before.
fastfrwrd
approved these changes
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eslint-plugin-reactwas updated (jsx-eslint/eslint-plugin-react#2408) to support a newstatic-variablesoption toreact/sort-comp. With this change, our linting started breaking. After some investigation, it turns out thatstaticsseems to refer to some oldReact.createClassoption, so static variables actually fell into the check forstatic-methods. Now that is fixed andstatic-methodsonly check for methods andstatic-variablesonly check for variables. So it doesn't seem like a breaking change, but we seem to have misused the options a bit.By only adding
static-variablesto our list we should still support older apps usingReact.createClass(if any), and everything will work again like before.