Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize ResponseInterceptor #1003

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

optimize ResponseInterceptor #1003

wants to merge 1 commit into from

Conversation

galaxy-sea
Copy link
Contributor

optimize ResponseInterceptor

spencergibb
spencergibb requested changes Mar 15, 2024
View reviewed changes
docs/modules/ROOT/pages/spring-cloud-openfeign.adoc
@@ -204,7 +204,9 @@ spring:
requestInterceptors:
- com.example.FooRequestInterceptor
- com.example.BarRequestInterceptor
responseInterceptor: com.example.BazResponseInterceptor
responseInterceptors:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change unfortunately

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello @spencergibb, Can compatibility be achieved? Keep responseInterceptor and add responseInterceptors

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@galaxy-sea It could be done, but seems rather messy in terms of the API. I think we will consider it for a major release if it's scheduled.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OlgaMaciaszek , I agree with your opinion

@galaxy-sea galaxy-sea mentioned this pull request Apr 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlgaMaciaszek OlgaMaciaszek OlgaMaciaszek left review comments

@spencergibb spencergibb spencergibb requested changes

Assignees
No one assigned
Labels
for major release waiting-for-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@galaxy-sea @spencergibb @OlgaMaciaszek @spring-cloud-issues