Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom HTTP status codes #1012

Merged

Conversation

pasichenko
Copy link
Contributor

Fixes #1010

@pivotal-cla
Copy link

@pasichenko Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@pasichenko Thank you for signing the Contributor License Agreement!

@pasichenko
Copy link
Contributor Author

pasichenko commented Apr 11, 2024

Hi @OlgaMaciaszek, can you review MR? The changes in this MR allow developers to reduce boilerplate code to add support for an API call that returns an HTTP code not specified in org.springframework.http.HttpStatus

@OlgaMaciaszek
Copy link
Collaborator

Hello @pasichenko, thanks for submitting the PR. We will definitely review it before the next release.

@OlgaMaciaszek OlgaMaciaszek added enhancement New feature or request and removed waiting-for-triage labels Apr 18, 2024
@OlgaMaciaszek OlgaMaciaszek self-assigned this Apr 18, 2024
Copy link
Collaborator

@OlgaMaciaszek OlgaMaciaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting the PR. LGTM.

@OlgaMaciaszek OlgaMaciaszek merged commit 596f9b3 into spring-cloud:main Apr 18, 2024
2 checks passed
@pasichenko pasichenko deleted the fix-support-custom-http-codes branch April 18, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom HTTP codes are not supported
4 participants