Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test support for @RequestMapping(path = "/"). Fixes gh-387. #409

Open
wants to merge 1 commit into
base: 2.2.x
Choose a base branch
from

Conversation

calaroche
Copy link

No description provided.

@pivotal-issuemaster
Copy link

@calaroche Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@calaroche Thank you for signing the Contributor License Agreement!

@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #409 into 2.2.x will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##              2.2.x     #409      +/-   ##
============================================
+ Coverage     79.02%   79.13%   +0.11%     
- Complexity      444      445       +1     
============================================
  Files            59       59              
  Lines          1740     1740              
  Branches        244      244              
============================================
+ Hits           1375     1377       +2     
+ Misses          257      256       -1     
+ Partials        108      107       -1     
Impacted Files Coverage Δ Complexity Δ
...ork/cloud/openfeign/support/SpringMvcContract.java 87.63% <0.00%> (+1.07%) 55.00% <0.00%> (+1.00%)

@OlgaMaciaszek
Copy link
Collaborator

Thanks, @calaroche. Will review this tomorrow.

@OlgaMaciaszek OlgaMaciaszek self-assigned this Oct 28, 2020
@OlgaMaciaszek OlgaMaciaszek added this to In progress in Hoxton.SR9 via automation Oct 28, 2020
@OlgaMaciaszek OlgaMaciaszek added this to In progress in 2020.0.0-M5 via automation Oct 28, 2020
@OlgaMaciaszek OlgaMaciaszek added this to the 2.2.6.RELEASE milestone Oct 28, 2020
Copy link
Collaborator

@OlgaMaciaszek OlgaMaciaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @calaroche In general, these tests are good and can be added anyway, they do not verify that issue. When you check out a commit before the fix (for example, d3da7e1), add these tests there and run them against that commit, they still pass. For this task, we will need to add a test that will fail against that commit and, therefore, reproduce the issue.

@spencergibb spencergibb removed this from In progress in Hoxton.SR9 Nov 9, 2020
@spencergibb spencergibb added this to In progress in Hoxton.SR10 via automation Nov 9, 2020
@spencergibb spencergibb removed this from In progress in 2020.0.0-M5 Nov 18, 2020
@spencergibb spencergibb added this to In progress in 2020.0.0-M6 via automation Nov 18, 2020
@ryanjbaxter ryanjbaxter removed this from In progress in 2020.0.0-M6 Dec 2, 2020
@ryanjbaxter ryanjbaxter added this to To do in 2020.0.0-RC1 via automation Dec 2, 2020
@ryanjbaxter ryanjbaxter added this to In progress in 2020.0.0 via automation Dec 14, 2020
@ryanjbaxter ryanjbaxter removed this from To do in 2020.0.0-RC1 Dec 14, 2020
@spencergibb spencergibb removed this from In progress in 2020.0.0 Dec 22, 2020
@spencergibb spencergibb added this to In progress in 2020.0.1 via automation Dec 22, 2020
@spencergibb spencergibb removed this from In progress in 2020.0.1 Jan 28, 2021
@spencergibb spencergibb added this to In progress in 2020.0.2 via automation Jan 28, 2021
@spencergibb spencergibb added this to In progress in Hoxton.x via automation Feb 11, 2021
@spencergibb spencergibb removed this from In progress in Hoxton.SR10 Feb 11, 2021
@spencergibb spencergibb removed this from In progress in 2020.0.2 Mar 18, 2021
@spencergibb spencergibb added this to In progress in 2020.0.x via automation Mar 18, 2021
@spencergibb spencergibb removed this from In progress in Hoxton.x Dec 3, 2021
@spencergibb spencergibb removed this from the 2.2.7.RELEASE milestone Feb 7, 2022
@spencergibb spencergibb added this to In progress in 2021.0.x via automation Feb 7, 2022
@spencergibb spencergibb removed this from In progress in 2020.0.x Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2021.0.x
In progress
Development

Successfully merging this pull request may close these issues.

None yet

5 participants