-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test support for @RequestMapping(path = "/"). Fixes gh-387. #409
base: 2.2.x
Are you sure you want to change the base?
Conversation
@calaroche Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@calaroche Thank you for signing the Contributor License Agreement! |
Codecov Report
@@ Coverage Diff @@
## 2.2.x #409 +/- ##
============================================
+ Coverage 79.02% 79.13% +0.11%
- Complexity 444 445 +1
============================================
Files 59 59
Lines 1740 1740
Branches 244 244
============================================
+ Hits 1375 1377 +2
+ Misses 257 256 -1
+ Partials 108 107 -1
|
Thanks, @calaroche. Will review this tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @calaroche In general, these tests are good and can be added anyway, they do not verify that issue. When you check out a commit before the fix (for example, d3da7e1), add these tests there and run them against that commit, they still pass. For this task, we will need to add a test that will fail against that commit and, therefore, reproduce the issue.
No description provided.