Lazy openfeign bean registration #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
without this change we're eagerly resolving placeholder properties in passed URLs / names. Since this happens at bean definition level it's extremely early e.g. Spring Cloud Contract has not yet registered any placeholders that Feign could try to consume. with this change we're changing the bean to become lazy initialized and we resolve the placeholder values at runtime - as late as possible. problems: - one of the tests uses the factory bean - there's no more factory bean since the instance supplier for the bean registration acts as one.
marcingrzejszczak
requested review from
ryanjbaxter,
spencergibb and
OlgaMaciaszek
Codecov Report
@@ Coverage Diff @@
## master #455 +/- ##
============================================
- Coverage 77.16% 76.72% -0.44%
- Complexity 434 436 +2
============================================
Files 54 54
Lines 1607 1633 +26
Branches 234 242 +8
============================================
+ Hits 1240 1253 +13
- Misses 252 257 +5
- Partials 115 123 +8
|
ryanjbaxter
approved these changes
Jan 12, 2021
OlgaMaciaszek
requested changes
Jan 12, 2021
marcingrzejszczak
changed the title
spencergibb
reviewed
Jan 12, 2021
| @@ -47,9 +48,10 @@ | |||
| "feign.client.config.default.loggerLevel=full", | |||
| "feign.client.config.default.requestInterceptors[0]=org.springframework.cloud.openfeign.FeignClientUsingPropertiesTests.FooRequestInterceptor", | |||
| "feign.client.config.default.requestInterceptors[1]=org.springframework.cloud.openfeign.FeignClientUsingPropertiesTests.BarRequestInterceptor" }) | |||
| @Ignore("I don't know how to test this since the factory bean is no longer created") | |||
There was a problem hiding this comment.
Why is the factory bean no longer created?
There was a problem hiding this comment.
From the initial PR comment: there's no more factory bean since the instance supplier for the bean registration acts as one
There was a problem hiding this comment.
Then that class should be removed and the test removed.
marcingrzejszczak
changed the title
marcingrzejszczak
added
enhancement
|
I would like you consider #443
Probably reusing AbstractFactoryBean patterns will decrease chance Spring-related problems |
|
#443 still exists on 3.0.1-SNAPSHOT It looks very suspicious to me that AbstractFactoryBean#getObject returns "early singleton proxy" and FeignClientFactoryBean#getObject returns "concrete bean". There must be a reason that base Spring class returns proxy |
|
Fixes gh-441. |
OlgaMaciaszek
pushed a commit
that referenced
this pull request
Jan 20, 2021
without this change we're eagerly resolving placeholder properties in passed URLs / names. Since this happens at bean definition level it's extremely early e.g. Spring Cloud Contract has not yet registered any placeholders that Feign could try to consume. with this change we're changing the bean to become lazy initialized and we resolve the placeholder values at runtime - as late as possible. Fixes gh-441. # Conflicts: # spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/FeignClientFactoryBean.java # spring-cloud-openfeign-core/src/main/java/org/springframework/cloud/openfeign/FeignClientsRegistrar.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without this change we're eagerly resolving placeholder properties in passed URLs / names. Since this happens at bean definition level it's extremely early e.g. Spring Cloud Contract has not yet registered any placeholders that Feign could try to consume.
with this change we're changing the bean to become lazy initialized and we resolve the placeholder values at runtime - as late as possible.
problems:
related issue spring-cloud/spring-cloud-contract#1303