Extend FeignCircuitBreaker builder #624
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Background ===== In December 2020, this project got support for [Spring Cloud CircuitBreaker](spring-cloud@63a5248). At the same time, [Hystrix support](spring-cloud@63a5248#diff-c296f2567f513e037087d5f9d6f44acf6752e6b066088447d99fccde837fb0cfL53-L57) was removed. Problem ===== In cases where people were creating the `HystrixFeignClient` manually using the `HystrixFeignBuilder`, and overriding properties such as `encoder(Encoder encoder)`, the new alternative does not support it. Example of the code working before: ```java HystrixFeign.builder() .encoder(jacksonEncoder) .decoder(jacksonDecoder) .target(MyClient.class, "https://api.my-url.com/", myFallback); ``` Currently, this is not supported, as the `FeignCircuitBreaker` does not override `encoder`, `decoder`, among others. Goal ====== To reestablish the previous functionality, so users can still create the Feign clients programmatically, while using custom encoders, and benefit from the circuit breaker.
|
@joaoqalves Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@joaoqalves Thank you for signing the Contributor License Agreement! |
OlgaMaciaszek
requested changes
Nov 23, 2021
There was a problem hiding this comment.
@joaoqalves thanks for submitting the PR. Please add tests and document your change (in spring-cloud-openfeign.adoc). Also, please add your full name and surname with @author tag to the javadocs of all the classes you've changed.
OlgaMaciaszek
added
in progress
enhancement
Codecov Report
@@ Coverage Diff @@
## main #624 +/- ##
============================================
- Coverage 78.87% 78.61% -0.27%
Complexity 535 535
============================================
Files 65 65
Lines 1955 1973 +18
Branches 271 271
============================================
+ Hits 1542 1551 +9
- Misses 264 273 +9
Partials 149 149
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
In December 2020, this project got support for
Spring Cloud CircuitBreaker.
At the same time, Hystrix support
was removed.
Problem
In cases where people were creating the
HystrixFeignClientmanuallyusing the
HystrixFeignBuilder, and overriding properties such asencoder(Encoder encoder), the new alternative does not support it.Example of the code working before:
Currently, this is not supported, as the
FeignCircuitBreakerdoesnot override
encoder,decoder, among others.Goal
To reestablish the previous functionality, so users can still create
the Feign clients programmatically, while using custom encoders, and
benefit from the circuit breaker.