Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated FlatFileItemWriter to eliminate empty line at EOF #3895

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updated FlatFileItemWriter to eliminate empty line at EOF #3895

wants to merge 1 commit into from

Conversation

parikshitdutta
Copy link
Contributor

  • updated FlatFileItemWriter to eliminate EOF line breaks, or, lineSeparator
  • added utility method in AbstractFileItemWriter to facilitate required changes in FlatFileItemWriter
  • updated an existing test to pass done changes
  • fixed expectedOutput file to pass usage of FlatFileItemReader

Closes #3863

@parikshitdutta parikshitdutta mentioned this pull request Apr 23, 2021
Closed
@jdomigon
Copy link

Hi. Have this changes been released in any version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
in: infrastructure pr-for: feature status: waiting-for-triage Issues that we did not analyse yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FlatFileItemWriter creates empy line at eof. Could we allow option to disable?
3 participants
@parikshitdutta @jdomigon @fmbenhassine