Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the JUnit dependency in AssertFile #4112

Closed
wants to merge 4 commits into from
Closed

Remove the JUnit dependency in AssertFile #4112

wants to merge 4 commits into from

Commits on Aug 23, 2022

  1. Updated AssertFile to use Jupiter package names 

    resolves spring-projects#4111
    @cppwfs
    cppwfs committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    984d3b3 View commit details
    Browse the repository at this point in the history

  2. Updated the Spring Samples Code to JUnit 5. 

    Since I had to add the dependency to the tests to have them pass because of the change made in the previous commit, I decided to migrate all tests to JUnit 5.

2 things to note:
* I used Spring's AssertionErrors on some AssertTrue or AssertFalse methods so that we could maintain the message.
* In a couple of cases the use of assertNotSame that was used had a message, but is no longer supported, so I removed those messages.
    @cppwfs
    cppwfs committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    d528111 View commit details
    Browse the repository at this point in the history

  3. Updated the AssertFile to remove the JUnit dependency 

    The side effect is a breaking change in that it will now throw IllegalStateException instead of the Compare and AssertExceptions provided by JUnit.
    @cppwfs
    cppwfs committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    dc115df View commit details
    Browse the repository at this point in the history

  4. Updated to do some polishing after rebase and merge

    @cppwfs
    cppwfs committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    70b8db2 View commit details
    Browse the repository at this point in the history