New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Javadocs #4129
Closed
Closed
Improve Javadocs #4129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cppwfs
reviewed
Jun 9, 2022
spring-batch-core/src/main/java/org/springframework/batch/core/configuration/StepRegistry.java
Show resolved
Hide resolved
...main/java/org/springframework/batch/core/configuration/annotation/EnableBatchProcessing.java
Outdated
Show resolved
Hide resolved
.../java/org/springframework/batch/core/configuration/support/ApplicationContextJobFactory.java
Show resolved
Hide resolved
...rc/main/java/org/springframework/batch/core/configuration/support/AutomaticJobRegistrar.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/springframework/batch/core/configuration/support/AutomaticJobRegistrar.java
Outdated
Show resolved
Hide resolved
...-core/src/main/java/org/springframework/batch/core/configuration/xml/CoreNamespaceUtils.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/org/springframework/batch/core/configuration/xml/SimpleFlowFactoryBean.java
Outdated
Show resolved
Hide resolved
...g-batch-core/src/main/java/org/springframework/batch/core/configuration/xml/SplitParser.java
Show resolved
Hide resolved
@@ -252,13 +250,19 @@ else if (job != null) { | |||
} | |||
} | |||
|
|||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct the indentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the problem. Can you provide more detail?
...rc/main/java/org/springframework/batch/core/configuration/xml/StepParserStepFactoryBean.java
Outdated
Show resolved
Hide resolved
Buzzardo
force-pushed
the
javadoc-editing
branch
from
July 14, 2022 15:31
ba1f4bf
to
59c8128
Compare
Rebased and merged as e6e21c5. Thank you Jay and Glenn!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for taking time to contribute this pull request!
You might have already read the contributor guide, but as a reminder, please make sure to:
main
branch and squash your commitsFor more details, please check the contributor guide.
Thank you upfront!