Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Javadocs #4129

Closed
wants to merge 2 commits into from
Closed

Conversation

Buzzardo
Copy link

@Buzzardo Buzzardo commented Jun 8, 2022

Thank you for taking time to contribute this pull request!
You might have already read the contributor guide, but as a reminder, please make sure to:

  • Sign the contributor license agreement
  • Rebase your changes on the latest main branch and squash your commits
  • Add/Update unit tests as needed
  • Run a build and make sure all tests pass prior to submission

For more details, please check the contributor guide.
Thank you upfront!

@cppwfs cppwfs self-assigned this Jun 8, 2022
@@ -252,13 +250,19 @@ else if (job != null) {
}
}

/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct the indentation.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the problem. Can you provide more detail?

@fmbenhassine
Copy link
Contributor

Rebased and merged as e6e21c5. Thank you Jay and Glenn!!

@fmbenhassine fmbenhassine changed the title More Javadoc editing Improve Javadocs Jul 20, 2022
@fmbenhassine fmbenhassine added this to the 5.0.0-M4 milestone Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants