BATCH-2515: Integrate SAP Hana as supported Spring Batch database #595
Conversation
breglerj
force-pushed
the
BATCH-2515
branch
from
c427833
to
508fff4
Compare
fmbenhassine
added
in: core
status: waiting-for-triage
fmbenhassine
removed
the
status: waiting-for-triage
|
|
||
| -- insert script that 'copies' existing batch_job_params to batch_job_execution_params | ||
| -- sets new params to identifying ones | ||
| -- verified on h2, |
There was a problem hiding this comment.
verified on h2
Is there a way to verify DDL scripts on a real SAP HANA instance? We have introduced Docker-based integration tests to verify DDL scripts on non-embeddable databases (see MySQLJobRepositoryIntegrationTests as an example). I see there is a Docker image for SAP HANA express edition (which requires an DockerHub account, but that's not an issue). Could you please add a Docker-based test for HANA?
There was a problem hiding this comment.
I have added an integration test based on the SQL Server test. Since the PR for adding HANA to testcontainers is still open I've added a simple version of the HANA container class to the test project.
...ng-batch-core/src/main/resources/org/springframework/batch/core/migration/migration-hana.sql
Outdated
Show resolved
Hide resolved
fmbenhassine
added
the
status: waiting-for-reporter
|
Hi @breglerj , Thank you for your PR! We are planning to add support for SAP HANA as a job repository in the next version, v5. The changes look good to me 👍 My only concern here is with testing. I'm not familiar with HANA so I would appreciate your help in making sure we can test this support on a real HANA instance. Please take a look at my comments above. Thank you. |
This commit adds SAP HANA as a supported Spring Batch database, enabling developers to seamlessly move their existing Spring Batch projects to SAP HANA or easily starting new Spring Batch projects on SAP HANA. This commit contains the following changes: - Add SAP HANA to the DatabaseType enum - Add HanaPagingQueryProvider and tests - Add properties files for SAP HANA
Hi @benas , I've updated this PR and incorporated your comments. Please let me know if you need anything else. Thanks. |
fmbenhassine
removed
the
status: waiting-for-reporter
- Update versions of jdbc driver and docker image - Update Javadocs - Remove JOB_CONFIGURATION_LOCATION from DDL schema - Remove unused resources
- Update versions of jdbc driver and docker image - Update Javadocs - Remove JOB_CONFIGURATION_LOCATION from DDL schema - Remove unused resources
- Update versions of jdbc driver and docker image - Update Javadocs - Remove JOB_CONFIGURATION_LOCATION from DDL schema - Remove unused resources
This commit adds SAP HANA as a supported Spring Batch database, enabling
developers to seamlessly move their existing Spring Batch projects to SAP HANA
or easily starting new Spring Batch projects on SAP HANA.
This commit contains the following changes:
HanaSequenceMaxValueIncrementer (see https://jira.spring.io/browse/SPR-16558)