Merge branch '2.2.x' into 2.3.x

Closes gh-22175
spring-projects · Jun 30, 2020 · 0e1ded6 · 0e1ded6
2 parents 4566ac5 + 500d2bd
commit 0e1ded6
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 5 deletions.
diff --git a/.../springframework/boot/autoconfigure/security/servlet/SecurityFilterAutoConfiguration.java b/.../springframework/boot/autoconfigure/security/servlet/SecurityFilterAutoConfiguration.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2019 the original author or authors.
+ * Copyright 2012-2020 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -73,7 +73,7 @@ private EnumSet<DispatcherType> getDispatcherTypes(SecurityProperties securityPr
 		}
 		return securityProperties.getFilter().getDispatcherTypes().stream()
 				.map((type) -> DispatcherType.valueOf(type.name()))
-				.collect(Collectors.collectingAndThen(Collectors.toSet(), EnumSet::copyOf));
+				.collect(Collectors.toCollection(() -> EnumSet.noneOf(DispatcherType.class)));
 	}
 
 }
diff --git a/.../org/springframework/boot/autoconfigure/session/SessionRepositoryFilterConfiguration.java b/.../org/springframework/boot/autoconfigure/session/SessionRepositoryFilterConfiguration.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2019 the original author or authors.
+ * Copyright 2012-2020 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -53,7 +53,7 @@ private EnumSet<DispatcherType> getDispatcherTypes(SessionProperties sessionProp
 			return null;
 		}
 		return servletProperties.getFilterDispatcherTypes().stream().map((type) -> DispatcherType.valueOf(type.name()))
-				.collect(Collectors.collectingAndThen(Collectors.toSet(), EnumSet::copyOf));
+				.collect(Collectors.toCollection(() -> EnumSet.noneOf(DispatcherType.class)));
 	}
 
 }
diff --git a/...g/springframework/boot/autoconfigure/security/servlet/SecurityAutoConfigurationTests.java b/...g/springframework/boot/autoconfigure/security/servlet/SecurityAutoConfigurationTests.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2019 the original author or authors.
+ * Copyright 2012-2020 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -164,6 +164,19 @@ void customFilterDispatcherTypes() {
 				});
 	}
 
+	@Test
+	void emptyFilterDispatcherTypesDoNotThrowException() {
+		this.contextRunner.withPropertyValues("spring.security.filter.dispatcher-types:")
+				.withConfiguration(AutoConfigurations.of(SecurityFilterAutoConfiguration.class)).run((context) -> {
+					DelegatingFilterProxyRegistrationBean bean = context.getBean("securityFilterChainRegistration",
+							DelegatingFilterProxyRegistrationBean.class);
+					@SuppressWarnings("unchecked")
+					EnumSet<DispatcherType> dispatcherTypes = (EnumSet<DispatcherType>) ReflectionTestUtils
+							.getField(bean, "dispatcherTypes");
+					assertThat(dispatcherTypes).isEmpty();
+				});
+	}
+
 	@Configuration(proxyBeanMethods = false)
 	@TestAutoConfigurationPackage(City.class)
 	static class EntityConfiguration {

diff --git a/...st/java/org/springframework/boot/autoconfigure/session/SessionAutoConfigurationTests.java b/...st/java/org/springframework/boot/autoconfigure/session/SessionAutoConfigurationTests.java
@@ -143,6 +143,17 @@ void filterDispatcherTypesCanBeCustomized() {
 				});
 	}
 
+	@SuppressWarnings("unchecked")
+	@Test
+	void emptyFilterDispatcherTypesDoNotThrowException() {
+		this.contextRunner.withUserConfiguration(SessionRepositoryConfiguration.class)
+				.withPropertyValues("spring.session.servlet.filter-dispatcher-types=").run((context) -> {
+					FilterRegistrationBean<?> registration = context.getBean(FilterRegistrationBean.class);
+					Object dispatcherTypes = ReflectionTestUtils.getField(registration, "dispatcherTypes");
+					assertThat((EnumSet<DispatcherType>) dispatcherTypes).isEmpty();
+				});
+	}
+
 	@Test
 	void sessionCookieConfigurationIsAppliedToAutoConfiguredCookieSerializer() {
 		this.contextRunner.withUserConfiguration(SessionRepositoryConfiguration.class)