Skip to content

Commit

Permalink
Revert "Make MeterRegistry lazy in TimerObservationHandlerObservation…
Browse files Browse the repository at this point in the history
…RegistryCustomizer"

This reverts commit 0439127.
  • Loading branch information
mhalbritter committed Jul 19, 2022
1 parent e35140d commit 5030cfe
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ static class MetricsConfiguration {

@Bean
TimerObservationHandlerObservationRegistryCustomizer enableTimerObservationHandler(
ObjectProvider<MeterRegistry> meterRegistry) {
MeterRegistry meterRegistry) {
return new TimerObservationHandlerObservationRegistryCustomizer(meterRegistry);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@
import io.micrometer.core.instrument.observation.TimerObservationHandler;
import io.micrometer.observation.ObservationRegistry;

import org.springframework.beans.factory.ObjectProvider;

/**
* Registers the {@link TimerObservationHandler} with an {@link ObservationRegistry}.
*
Expand All @@ -30,15 +28,15 @@
class TimerObservationHandlerObservationRegistryCustomizer
implements ObservationRegistryCustomizer<ObservationRegistry> {

private final ObjectProvider<MeterRegistry> meterRegistry;
private final MeterRegistry meterRegistry;

TimerObservationHandlerObservationRegistryCustomizer(ObjectProvider<MeterRegistry> meterRegistry) {
TimerObservationHandlerObservationRegistryCustomizer(MeterRegistry meterRegistry) {
this.meterRegistry = meterRegistry;
}

@Override
public void customize(ObservationRegistry registry) {
registry.observationConfig().observationHandler(new TimerObservationHandler(this.meterRegistry.getObject()));
registry.observationConfig().observationHandler(new TimerObservationHandler(this.meterRegistry));
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@
import io.micrometer.observation.Observation;
import io.micrometer.observation.ObservationRegistry;
import org.junit.jupiter.api.Test;
import org.mockito.Mockito;

import org.springframework.beans.factory.ObjectProvider;

import static org.assertj.core.api.Assertions.assertThat;

Expand All @@ -35,13 +32,10 @@
class TimerObservationHandlerObservationRegistryCustomizerTests {

@Test
@SuppressWarnings("unchecked")
void customizeInstallsTimerObservationHandler() {
MeterRegistry meterRegistry = new SimpleMeterRegistry();
ObjectProvider<MeterRegistry> meterRegistryProvider = Mockito.mock(ObjectProvider.class);
Mockito.when(meterRegistryProvider.getObject()).thenReturn(meterRegistry);
TimerObservationHandlerObservationRegistryCustomizer sut = new TimerObservationHandlerObservationRegistryCustomizer(
meterRegistryProvider);
meterRegistry);
ObservationRegistry observationRegistry = ObservationRegistry.create();
sut.customize(observationRegistry);
Observation.start("test-1", observationRegistry).stop();
Expand Down

0 comments on commit 5030cfe

Please sign in to comment.