Skip to content

Commit

Permalink
Only disable test tasks when a project isn't compatible with toolchain
Browse files Browse the repository at this point in the history
Disabling compilation means that any downstream project will break.
For example, disabling our Gradle plugin's compileJava task means
that the launch script test app fails to build as it uses our
Gradle plugin and its classes are missing.

See gh-gh-32280
  • Loading branch information
wilkinsona committed Sep 10, 2022
1 parent 4523f01 commit 5cb23ae
Showing 1 changed file with 0 additions and 4 deletions.
Expand Up @@ -23,8 +23,6 @@
import org.gradle.api.Plugin;
import org.gradle.api.Project;
import org.gradle.api.plugins.JavaPluginExtension;
import org.gradle.api.tasks.compile.JavaCompile;
import org.gradle.api.tasks.javadoc.Javadoc;
import org.gradle.api.tasks.testing.Test;
import org.gradle.jvm.toolchain.JavaLanguageVersion;
import org.gradle.jvm.toolchain.JavaToolchainSpec;
Expand Down Expand Up @@ -67,8 +65,6 @@ private boolean isJavaVersionSupported(ToolchainExtension toolchain, JavaLanguag
}

private void disableToolchainTasks(Project project) {
project.getTasks().withType(JavaCompile.class, (task) -> task.setEnabled(false));
project.getTasks().withType(Javadoc.class, (task) -> task.setEnabled(false));
project.getTasks().withType(Test.class, (task) -> task.setEnabled(false));
}

Expand Down

0 comments on commit 5cb23ae

Please sign in to comment.