Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Narrow criteria for hidden property paths
A previous change intended to prevent temporary directories created as an implementation detail of mounting volumes on kubernetes pods from being used as a source for property files had a side-effect of also preventing other types of hidden directories from being recognized. This commit narrows the criteria for considering a directory as hidden, using the kubernetes `..` prefix convention instead of the Unix `.` prefix. Fixes gh-23983
- Loading branch information
62aa1b7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might it be better to call the method "hasTempPathElement" or "hasK8sHiddenPathElement"?
Hidden path elements should not be prevented.
62aa1b7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't a fix for the problem. We have a custom script that collects mounted configmaps in k8s and resolves paths. This results in config locations like:
/config/autoloaded/our-app/..2020_10_27_21_10_29.797568129/application.properties
This happens because everything not in..DATE
is a symlink.