Skip to content

Commit

Permalink
Allow to exclude an empty set of ErrorAttributes
Browse files Browse the repository at this point in the history
  • Loading branch information
wanderleisouza authored and snicoll committed Nov 23, 2020
1 parent 4e9f702 commit 6518f8f
Show file tree
Hide file tree
Showing 2 changed files with 54 additions and 1 deletion.
Expand Up @@ -27,6 +27,7 @@
*
* @author Scott Frederick
* @author Phillip Webb
* @author Wanderlei Souza
* @since 2.3.0
*/
public final class ErrorAttributeOptions {
Expand Down Expand Up @@ -76,7 +77,8 @@ public ErrorAttributeOptions including(Include... includes) {
* @return an {@code ErrorAttributeOptions}
*/
public ErrorAttributeOptions excluding(Include... excludes) {
EnumSet<Include> updated = EnumSet.copyOf(this.includes);
EnumSet<Include> updated = (this.includes.isEmpty()) ? EnumSet.noneOf(Include.class)
: EnumSet.copyOf(this.includes);
updated.removeAll(Arrays.asList(excludes));
return new ErrorAttributeOptions(Collections.unmodifiableSet(updated));
}
Expand Down
@@ -0,0 +1,51 @@
/*
* Copyright 2012-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.springframework.boot.web.servlet.error;

import static org.assertj.core.api.Assertions.assertThat;

import java.util.EnumSet;
import java.util.Set;

import org.junit.jupiter.api.Test;
import org.springframework.boot.web.error.ErrorAttributeOptions;
import org.springframework.boot.web.error.ErrorAttributeOptions.Include;

/**
* Tests for {@link ErrorAttributesOptions}.
*
* @author Wanderlei Souza
*/
class ErrorAttributesOptionsTests {

@Test
void excludingFromEmptySetWithoutErrors() {
Set<Include> includes = EnumSet.noneOf(Include.class);
ErrorAttributeOptions errorAttributeOptions = ErrorAttributeOptions.of(includes);
errorAttributeOptions = errorAttributeOptions.excluding(Include.EXCEPTION);
assertThat(errorAttributeOptions.getIncludes().isEmpty());
}

@Test
void includingInEmptySetWithoutErrors() {
Set<Include> includes = EnumSet.noneOf(Include.class);
ErrorAttributeOptions errorAttributeOptions = ErrorAttributeOptions.of(includes);
errorAttributeOptions = errorAttributeOptions.including(Include.EXCEPTION);
assertThat(errorAttributeOptions.getIncludes().isEmpty());
}

}

0 comments on commit 6518f8f

Please sign in to comment.