Fix empty @DefaultValue annotation test failures on Java 17

See gh-32559
spring-projects · Oct 1, 2022 · 75f4d9e · 75f4d9e
1 parent efc431b
commit 75f4d9e
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/...oot/src/main/java/org/springframework/boot/context/properties/bind/ValueObjectBinder.java b/...oot/src/main/java/org/springframework/boot/context/properties/bind/ValueObjectBinder.java
@@ -131,10 +131,6 @@ private <T> T getNewDefaultValueInstanceIfPossible(Binder.Context context, Resol
 		Class<T> resolved = (Class<T>) type.resolve();
 		Assert.state(resolved == null || isEmptyDefaultValueAllowed(resolved),
 				() -> "Parameter of type " + type + " must have a non-empty default value.");
-		T instance = create(Bindable.of(type), context);
-		if (instance != null) {
-			return instance;
-		}
 		if (resolved != null) {
 			if (Optional.class == resolved) {
 				return (T) Optional.empty();
@@ -148,9 +144,12 @@ private <T> T getNewDefaultValueInstanceIfPossible(Binder.Context context, Resol
 			if (resolved.isArray()) {
 				return (T) Array.newInstance(resolved.getComponentType(), 0);
 			}
-			return BeanUtils.instantiateClass(resolved);
 		}
-		return null;
+		T instance = create(Bindable.of(type), context);
+		if (instance != null) {
+			return instance;
+		}
+		return (resolved != null) ? BeanUtils.instantiateClass(resolved) : null;
 	}
 
 	private boolean isEmptyDefaultValueAllowed(Class<?> type) {