Skip to content

Commit

Permalink
Merge branch '2.2.x' into 2.3.x
Browse files Browse the repository at this point in the history
Closes gh-22167
  • Loading branch information
wilkinsona committed Jun 30, 2020
2 parents f86831d + 64aa418 commit 75fc140
Show file tree
Hide file tree
Showing 2 changed files with 41 additions and 1 deletion.
Expand Up @@ -86,7 +86,9 @@ private Context findContext(TomcatWebServer tomcatWebServer) {

@Override
public void destroy() {
this.tomcatMetrics.close();
if (this.tomcatMetrics != null) {
this.tomcatMetrics.close();
}
}

}
@@ -0,0 +1,38 @@
/*
* Copyright 2012-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.springframework.boot.actuate.metrics.web.tomcat;

import io.micrometer.core.instrument.MeterRegistry;
import org.junit.jupiter.api.Test;

import static org.mockito.Mockito.mock;

/**
* Tests for {@link TomcatMetricsBinder}.
*
* @author Andy Wilkinson
*/
class TomcatMetricsBinderTests {

private final MeterRegistry meterRegistry = mock(MeterRegistry.class);

@Test
void destroySucceedsWhenCalledBeforeApplicationHasStarted() {
new TomcatMetricsBinder(this.meterRegistry).destroy();
}

}

0 comments on commit 75fc140

Please sign in to comment.