Catch isEmbedded failure and treat database as not embedded

Fixes gh-26926
spring-projects · Jun 17, 2021 · 7ee3b28 · 7ee3b28
1 parent 7cd2d64
commit 7ee3b28
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/...src/main/java/org/springframework/boot/jdbc/init/DataSourceScriptDatabaseInitializer.java b/...src/main/java/org/springframework/boot/jdbc/init/DataSourceScriptDatabaseInitializer.java
@@ -21,6 +21,9 @@
 
 import javax.sql.DataSource;
 
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
+
 import org.springframework.beans.factory.InitializingBean;
 import org.springframework.boot.jdbc.EmbeddedDatabaseConnection;
 import org.springframework.boot.sql.init.AbstractScriptDatabaseInitializer;
@@ -38,6 +41,8 @@
  */
 public class DataSourceScriptDatabaseInitializer extends AbstractScriptDatabaseInitializer {
 
+	private static final Log logger = LogFactory.getLog(DataSourceScriptDatabaseInitializer.class);
+
 	private final DataSource dataSource;
 
 	/**
@@ -61,7 +66,13 @@ protected final DataSource getDataSource() {
 
 	@Override
 	protected boolean isEmbeddedDatabase() {
-		return EmbeddedDatabaseConnection.isEmbedded(this.dataSource);
+		try {
+			return EmbeddedDatabaseConnection.isEmbedded(this.dataSource);
+		}
+		catch (Exception ex) {
+			logger.debug("Could not determine if datasource is embedded", ex);
+			return false;
+		}
 	}
 
 	@Override

diff --git a/...est/java/org/springframework/boot/jdbc/init/DataSourceScriptDatabaseInitializerTests.java b/...est/java/org/springframework/boot/jdbc/init/DataSourceScriptDatabaseInitializerTests.java
@@ -22,6 +22,7 @@
 
 import com.zaxxer.hikari.HikariDataSource;
 import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.Test;
 
 import org.springframework.boot.jdbc.DataSourceBuilder;
 import org.springframework.boot.sql.init.AbstractScriptDatabaseInitializerTests;
@@ -53,6 +54,13 @@ void closeDataSource() {
 		this.standloneDataSource.close();
 	}
 
+	@Test
+	void whenDatabaseIsInaccessibleThenItIsAssumedNotToBeEmbedded() {
+		DataSourceScriptDatabaseInitializer initializer = new DataSourceScriptDatabaseInitializer(
+				new HikariDataSource(), new DatabaseInitializationSettings());
+		assertThat(initializer.isEmbeddedDatabase()).isFalse();
+	}
+
 	@Override
 	protected DataSourceScriptDatabaseInitializer createEmbeddedDatabaseInitializer(
 			DatabaseInitializationSettings settings) {