Merge branch '2.3.x'

See gh-24053
spring-projects · Nov 5, 2020 · ce84277 · ce84277
2 parents 06f37f4 + 91f4541
commit ce84277
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/...ot/src/main/java/org/springframework/boot/web/embedded/tomcat/SslConnectorCustomizer.java b/...ot/src/main/java/org/springframework/boot/web/embedded/tomcat/SslConnectorCustomizer.java
@@ -148,7 +148,9 @@ private void configureSslTrustStore(AbstractHttp11JsseProtocol<?> protocol, Ssl
 				throw new WebServerException("Could not load trust store: " + ex.getMessage(), ex);
 			}
 		}
-		protocol.setTruststorePass(ssl.getTrustStorePassword());
+		if (ssl.getTrustStorePassword() != null) {
+			protocol.setTruststorePass(ssl.getTrustStorePassword());
+		}
 		if (ssl.getTrustStoreType() != null) {
 			protocol.setTruststoreType(ssl.getTrustStoreType());
 		}

diff --git a/...c/test/java/org/springframework/boot/web/embedded/tomcat/SslConnectorCustomizerTests.java b/...c/test/java/org/springframework/boot/web/embedded/tomcat/SslConnectorCustomizerTests.java
@@ -206,6 +206,17 @@ void keyPasswordIsNotSetWhenNull() {
 		assertThat(protocol.getKeyPass()).isEqualTo("password");
 	}
 
+	@Test
+	void trustStorePasswordIsNotSetWhenNull() {
+		Http11NioProtocol protocol = (Http11NioProtocol) this.tomcat.getConnector().getProtocolHandler();
+		protocol.setTruststorePass("password");
+		Ssl ssl = new Ssl();
+		ssl.setKeyStore("src/test/resources/test.jks");
+		ssl.setTrustStore("src/test/resources/test.jks");
+		new SslConnectorCustomizer(ssl, null).customize(this.tomcat.getConnector());
+		assertThat(protocol.getTruststorePass()).isEqualTo("password");
+	}
+
 	private KeyStore loadStore() throws KeyStoreException, IOException, NoSuchAlgorithmException, CertificateException {
 		KeyStore keyStore = KeyStore.getInstance("JKS");
 		Resource resource = new ClassPathResource("test.jks");