You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
AbstractRepositoryConfigurationSourceSupport overrides one of the registerBeanDefinitions() method in ImportBeanDefinitionRegistrar but not the other. The other one has an empty default implementation, so if anyone calls it, nothing happens. It would be helpful to add an implementation, even if it just throws an exception (hopefully it wouldn't need to).
The text was updated successfully, but these errors were encountered:
wilkinsona
changed the title
Add implementation for empty registerBeanDefinitions() method
AbstractRepositoryConfigurationSourceSupport does not override registerBeanDefinitions(AnnotationMetadata, BeanDefinitionRegistry)
Jul 23, 2020
The BeanNameGenerator that's missing when registerBeanDefinitions(AnnotationMetadata, BeanDefinitionRegistry) is called is eventually passed into an AnnotationRepositoryConfigurationSource constructor where it's marked as @Nullable. It looks like we can safely implement the missing override as follows:
AbstractRepositoryConfigurationSourceSupport
overrides one of theregisterBeanDefinitions()
method inImportBeanDefinitionRegistrar
but not the other. The other one has an empty default implementation, so if anyone calls it, nothing happens. It would be helpful to add an implementation, even if it just throws an exception (hopefully it wouldn't need to).The text was updated successfully, but these errors were encountered: