Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YamlPropertySourceLoader may not use the right ClassLoader to check if SnakeYAML is present #27133

Closed
jaminh opened this issue Jul 1, 2021 · 2 comments
Labels
type: bug A general bug
Milestone

Comments

@jaminh
Copy link
Contributor

jaminh commented Jul 1, 2021

Similar to issues #27071 and #27072 the YamlPropertySourceLoader does not use an alternate classloader if one is provided to the SpringApplication. The problem can be found here

.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 1, 2021
@philwebb philwebb added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 7, 2021
@philwebb philwebb added this to the 2.4.x milestone Jul 7, 2021
@wilkinsona
Copy link
Member

Let's roll this into #27134.

@wilkinsona wilkinsona removed this from the 2.4.x milestone Jul 20, 2021
@wilkinsona wilkinsona added the status: duplicate A duplicate of another issue label Jul 20, 2021
@wilkinsona
Copy link
Member

Having gone through the possible problems listed in #27134 and some more that weren't listed, I've changed my mind about this one. I'm leaning towards just fixing this specific case and leaving the others as-is until they cause a problem for someone. IMO, the possible risk of regression outweighs the benefits at the moment.

@wilkinsona wilkinsona reopened this Jul 20, 2021
@wilkinsona wilkinsona removed the status: duplicate A duplicate of another issue label Jul 20, 2021
@wilkinsona wilkinsona added this to the 2.4.x milestone Jul 20, 2021
@wilkinsona wilkinsona modified the milestones: 2.4.x, 2.4.9 Jul 20, 2021
@wilkinsona wilkinsona changed the title YamlPropertySourceLoader doesn't use alternate classloader YamlPropertySourceLoader may not use the right ClassLoader to check if SnakeYAML is present Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

4 participants