Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Traces are propagated if tracing is disabled #38641

Closed
quaff opened this issue Dec 4, 2023 · 2 comments
Closed

Traces are propagated if tracing is disabled #38641

quaff opened this issue Dec 4, 2023 · 2 comments
Assignees
@mhalbritter
Labels
type: regression A regression from a previous release
Milestone
3.2.1

Comments

@quaff
Copy link
Contributor

quaff commented Dec 4, 2023

According to #38625 (comment), management.tracing.enabled is used to disable tracing only in tests currently, If we want to dynamic disable tracing entirely we have to exclude AutoConfiguration by spring.autoconfigure.exclude, That's not handy especially for profile combination.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 4, 2023
@mhalbritter mhalbritter added the for: team-meeting An issue we'd like to discuss as a team to make progress label Dec 4, 2023
@philwebb philwebb changed the title Disable tracing for product code if management.tracing.enabled=false Disable tracing for product code if management.tracing.enabled=false Dec 4, 2023
@philwebb philwebb changed the title Disable tracing for product code if management.tracing.enabled=false Disable tracing for product code if 'management.tracing.enabled=false' Dec 4, 2023
@philwebb
Copy link
Member

philwebb commented Dec 4, 2023

We discussed this today and we'd like to make it so that management.tracing.enabled also disables the propagation of traces (probably by adding conditions to brave and otel beans).

@philwebb philwebb added type: regression A regression from a previous release and removed status: waiting-for-triage An issue we've not yet triaged for: team-meeting An issue we'd like to discuss as a team to make progress labels Dec 4, 2023
@philwebb philwebb added this to the 3.2.x milestone Dec 4, 2023
@mhalbritter mhalbritter changed the title Disable tracing for product code if 'management.tracing.enabled=false' Disable trace propagation if tracing is disabled Dec 5, 2023
@mhalbritter mhalbritter modified the milestones: 3.2.x, 3.2.1 Dec 5, 2023
This was referenced Dec 5, 2023
Closed
Closed
Closed
@mhalbritter
Copy link
Contributor

mhalbritter commented Dec 5, 2023 •
edited

I reworded the management.tracing.enabled property description in the documenation. That property will now disable trace exporting (sending traces to backends) and also trace propagation (e.g. sending trace and span ids via http for example). This is done by providing a noop Propagation.Factory for Brave and a noop TextMapPropagator for OpenTelemetry.

@mhalbritter mhalbritter changed the title Disable trace propagation if tracing is disabled Traces are propagated even if tracing is disabled Dec 5, 2023
@mhalbritter mhalbritter changed the title Traces are propagated even if tracing is disabled Traces are propagated if tracing is disabled Dec 5, 2023
This was referenced Dec 22, 2023
Closed
Closed
@danielhcx danielhcx mentioned this issue Jan 30, 2024
Open
@najibk najibk mentioned this issue Feb 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhalbritter mhalbritter

Labels
type: regression A regression from a previous release
Projects
None yet
Milestone
3.2.1
Development

No branches or pull requests
4 participants
@quaff @philwebb @spring-projects-issues @mhalbritter