Set LOG_CORRELATION_PATTERN only when correlation ID is expected #39333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, if `logging.pattern.correlation` has been set, then the correlation ID is logged regardless of the flag `logging.expect-correlation-id`. This is different from what happens with the default correlation patterns. This commit updates LoggingSystemProperties so that the system property `LOG_CORRELATION_PATTERN` is set when `logging.expect-correlation-id` is `true`. If it is `false` then the correlation ID won't be logged in any cases.
spring-projects-issues
added
the
status: waiting-for-triage
Format the code by running the `format` Gradle task.
|
Thanks for the PR. This looks sensible to me but I'd like to double-check with the rest of the team and @jonatan-ivanov. |
wilkinsona
added
the
for: team-attention
philwebb
changed the title
LOG_CORRELATION_PATTERN only when correlation ID is expected
philwebb
removed
the
for: team-attention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, if
logging.pattern.correlationhas been set, then the correlation ID is logged regardless of the flaglogging.expect-correlation-id. This is different from what happens with the default correlation patterns.This commit updates LoggingSystemProperties so that the system property
LOG_CORRELATION_PATTERNis set whenlogging.expect-correlation-idistrue. If it isfalsethen the correlation ID won't be logged in any cases.This also follows gh-38641 from the perspective of logging.