Log error before emitting application failed event #14980
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jorgefr Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@jorgefr This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary. |
With the previous implementation, the error never gets logged, because the SLF4JBridgeHandler is removed from the root logger as a response to the ApplicationFailedEvent
|
Unfortunately we can't switch the logging in exactly the way that you've suggested. The existing |
philwebb
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is simplest possible solution.
With the previous implementation, the error never gets logged, because the
SLF4JBridgeHandleris removed from the root logger as a response to theApplicationFailedEventSome details about it:
#14979
Obvious Fix