Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ErrorAttributeOptions.excluding throws IllegalArgumentException if includes is empty #24230

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -27,6 +27,7 @@
*
* @author Scott Frederick
* @author Phillip Webb
* @author Wanderlei Souza
* @since 2.3.0
*/
public final class ErrorAttributeOptions {
Expand Down Expand Up @@ -76,7 +77,8 @@ public ErrorAttributeOptions including(Include... includes) {
* @return an {@code ErrorAttributeOptions}
*/
public ErrorAttributeOptions excluding(Include... excludes) {
EnumSet<Include> updated = EnumSet.copyOf(this.includes);
EnumSet<Include> updated = (this.includes.isEmpty()) ? EnumSet.noneOf(Include.class)
: EnumSet.copyOf(this.includes);
updated.removeAll(Arrays.asList(excludes));
return new ErrorAttributeOptions(Collections.unmodifiableSet(updated));
}
Expand Down
@@ -0,0 +1,51 @@
/*
* Copyright 2012-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.springframework.boot.web.servlet.error;

import static org.assertj.core.api.Assertions.assertThat;

import java.util.EnumSet;
import java.util.Set;

import org.junit.jupiter.api.Test;
import org.springframework.boot.web.error.ErrorAttributeOptions;
import org.springframework.boot.web.error.ErrorAttributeOptions.Include;

/**
* Tests for {@link ErrorAttributesOptions}.
*
* @author Wanderlei Souza
*/
class ErrorAttributesOptionsTests {

@Test
void excludingFromEmptySetWithoutErrors() {
Set<Include> includes = EnumSet.noneOf(Include.class);
ErrorAttributeOptions errorAttributeOptions = ErrorAttributeOptions.of(includes);
errorAttributeOptions = errorAttributeOptions.excluding(Include.EXCEPTION);
assertThat(errorAttributeOptions.getIncludes().isEmpty());
}

@Test
void includingInEmptySetWithoutErrors() {
Set<Include> includes = EnumSet.noneOf(Include.class);
ErrorAttributeOptions errorAttributeOptions = ErrorAttributeOptions.of(includes);
errorAttributeOptions = errorAttributeOptions.including(Include.EXCEPTION);
assertThat(errorAttributeOptions.getIncludes().isEmpty());
}

}