Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Java 17 to JavaVersion enum #26769

Closed
wants to merge 2 commits into from
Closed

Add Java 17 to JavaVersion enum #26769

wants to merge 2 commits into from

Conversation

dreis2211
Copy link
Contributor

Hi,

this is the first tiny step for #26767 by adding Java 17 to the known versions.

Cheers,
Christoph

@dreis2211 dreis2211 mentioned this pull request Jun 5, 2021
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 5, 2021
snicoll
snicoll reviewed Jun 5, 2021
View reviewed changes
Copy link
Member

@snicoll snicoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be in favor of adding this once we have a better view on what's required to have a green build with Java 17. WDYT?

@dreis2211
Copy link
Contributor Author

dreis2211 commented Jun 6, 2021 •
edited

The class comment of JavaVersion says Known Java versions. and not Supported Java Versions. I always saw it similar to Gradle's JavaVersion enum that includes 17 on version 6.9 already while not supporting it.

I don't have strong feelings against holding this back until we have a better picture for Java 17, but for me JavaVersion is not really connected to either running or supporting the respective version. Rather an acknowledgement of the version - nothing more nothing less. But in the end it's totally fine if this PR is staying open for a while - it's not really needed to get a green build for Java 17 anyway.

@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 8, 2021
@philwebb philwebb modified the milestones: 2.6.x, 2.5.x Jun 8, 2021
@wilkinsona wilkinsona modified the milestones: 2.5.x, 2.5.3 Jul 20, 2021
wilkinsona pushed a commit that referenced this pull request Jul 20, 2021
@dreis2211 @wilkinsona
Add Java 17 to JavaVersion enum
0ea3b92 
See gh-26769
@wilkinsona
Copy link
Member

Thanks once again, @dreis2211.

@wilkinsona wilkinsona mentioned this pull request Jul 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snicoll snicoll snicoll left review comments

Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.5.3
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dreis2211 @wilkinsona @snicoll @philwebb @spring-projects-issues