Update optaplanner spring boot starter url #26816
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
requested changes
Jun 8, 2021
| @@ -182,7 +182,7 @@ do as they were designed before this was clarified. | |||
| | https://github.com/okta/okta-spring-boot | |||
|
|
|||
| | https://www.optaplanner.org/[OptaPlanner] | |||
| | https://github.com/kiegroup/optaplanner/tree/master/optaplanner-integration/optaplanner-spring-boot-starter | |||
| | https://github.com/kiegroup/optaplanner/tree/master/optaplanner-spring-integration/optaplanner-spring-boot-starter (https://github.com/kiegroup/optaplanner-quickstarts/tree/stable/spring-boot-school-timetabling[quickstart example]) | |||
There was a problem hiding this comment.
Please revert the quickstart link. None of the other entries have such a link and I am not keen to introduce that. You can make sure the quickstart guide is prominent in whatever link you provide here.
There was a problem hiding this comment.
No problem, I see this issue was already fixed, so no need for me to adjust this myself. Thank you for merging.
snicoll
added
the
status: waiting-for-feedback
philwebb
added
type: documentation
snicoll
pushed a commit
that referenced
this pull request
Jun 10, 2021
snicoll
added a commit
that referenced
this pull request
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous URL is 404 now.
I also added the quickstart link, FWIW.