Avoid illegal reflective access on ZipEntry.xdostime #27100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
This was referenced Jun 25, 2021
philwebb
added
type: task
|
Thanks very much, @dreis2211. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR provides an alternative solution for the illegal reflective access on
ZipEntry.xdostimeinsideJarFileTests.jarFileEntryWithEpochTimeOfZeroShouldNotFailand is part of the overall JDK 17 story at #26767.As per comment from @AlanBateman I took another look and found that the JDK is testing things a bit differently for similar scenarios that doesn't require reflection or opening up modules. See ZeroDate.java
The idea is basically to change the necessary bytes in the actual file. Also not too pretty, I must say. But it's reflection free and doesn't access any internals anymore.
Let me know what you think.
Cheers,
Christoph