AbstractDataSourceInitializers are not detected as database initializers #27215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
added
type: bug
wilkinsona
changed the title
|
Thank you, @hpoettker. This is what I had in mind for the Batch side of things in 2.5. For 2.4 things are quite different and I've fixed that in #27193 . I've realised that the problem's a bit broader as Spring Session JDBC has a similar problem and we can refine the Quartz configuration as well once we've got the necessary detection in place. I'll merge (some of) the changes proposed here – which will take care of #27207 – and then make some changes that build on top of them in separate issues. |
|
@hpoettker Thanks once again for making your first contribution to Spring Boot. |
wilkinsona
pushed a commit
that referenced
this pull request
Jul 9, 2021
wilkinsona
added a commit
that referenced
this pull request
Jul 9, 2021
|
I've merged the Batch-specific parts of the originally-proposed changes in this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wilkinsona Thanks for the feedback on #27144. I think this is the approach you suggested.
Issue #27193