Disable failing Gradle plugin tests on JDK 17 #27328
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
dreis2211
commented
Jul 14, 2021
| @@ -57,6 +57,9 @@ | |||
|
|
|||
| @Override | |||
| public Stream<TestTemplateInvocationContext> provideTestTemplateInvocationContexts(ExtensionContext context) { | |||
| if (JavaVersion.current() == JavaVersion.VERSION_17) { | |||
| return Stream.of(new DisabledTemplateInvocationContext()); | |||
There was a problem hiding this comment.
Unfortunately, we can't just return an empty stream here. JUnit is expecting at least one invocation context
wilkinsona
added
type: task
wilkinsona
pushed a commit
that referenced
this pull request
Jul 16, 2021
|
LGTM! Thanks very much once again, @dreis2211. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this is the last open item before we can create a JDK 17 pipeline - see #26767.
I wanted to make an effort to not just exclude the whole module (or all of its tests) via CI, but test as much as we can. The added helper classes that we need to workaround the shortcomings of Gradle, will be likely removed again as soon as Gradle is ready for JDK 17. Since they're not published and only test relevant, I figured this to be acceptable. The fact that it's more fine-grained and explicit was appealing to me, but I could also exclude all tests with some hackery in CI (we did this in the past). Neither solution is beautiful if you ask me, but I went for the one that keeps more test coverage.
Let me know what you think.
Cheers,
Christoph