Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure App Service is not correctly detected on Windows #27819

Closed
wants to merge 3 commits into from

Conversation

jdubois
Copy link
Contributor

@jdubois jdubois commented Aug 25, 2021

This follows the discussion in #27657 - but I used 4 variables instead of 3, to reduce the risk even more!

@jdubois
Copy link
Contributor Author

jdubois commented Aug 26, 2021

Forcing a new build as the CI failed, but the error message seems to be about a failing "git pull"

@snicoll
Copy link
Member

snicoll commented Aug 26, 2021

@jdubois there's no need to force a new CI build.

@jdubois
Copy link
Contributor Author

jdubois commented Aug 26, 2021

Sorry @snicoll I don't know how Concourse works! Just found the issue and fixed it.

@jdubois
Copy link
Contributor Author

jdubois commented Aug 26, 2021

If you ever want to move to GitHub Actions please ping me (that's Microsoft and the runners are on Azure!)

@snicoll
Copy link
Member

snicoll commented Aug 26, 2021

Going forward, please build locally before submitting the PR. The formatting errors are checked by the build, not CI.

@jdubois
Copy link
Contributor Author

jdubois commented Aug 26, 2021

Yes sorry, I just ran the test locally, last time I did a build it took like 2 hours on my Mac

@snicoll
Copy link
Member

snicoll commented Aug 26, 2021

This PR only touches files on the spring-boot module, ./gradlew :spring-boot-project:spring-boot:check took 23s to build for me.

@snicoll snicoll self-assigned this Sep 6, 2021
@snicoll snicoll modified the milestones: 2.5.x, 2.5.5 Sep 6, 2021
@snicoll snicoll changed the title Use the correct env variables to detect Azure App Service Azure App Service is not correctly detected on Windows Sep 6, 2021
@snicoll snicoll closed this in 222a570 Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants