Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server.servlet.session.cookie.same-site isn't applied to Spring Session's SESSION cookie #28784

Closed
wants to merge 1 commit into from

Conversation

vpavic
Copy link
Contributor

@vpavic vpavic commented Nov 23, 2021

This commit adds the mapping of server.servlet.session.cookie.same-site configuration property to DefaultCookieSerializer bean configured in the Spring Session auto-configuration.

See gh-28772

…lizer

This commit adds the mapping of `server.servlet.session.cookie.same-site` configuration property to `DefaultCookieSerializer` bean configured in the Spring Session auto-configuration.

See spring-projectsgh-28772
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 23, 2021
@philwebb philwebb added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 29, 2021
@philwebb philwebb added this to the 2.6.x milestone Nov 29, 2021
@snicoll snicoll self-assigned this Dec 9, 2021
@snicoll snicoll modified the milestones: 2.6.x, 2.6.2 Dec 9, 2021
@snicoll snicoll changed the title Apply SameSite session cookie property to Spring Session cookie serializer server.servlet.session.cookie.same-site isn't applied to Spring Session's SESSION cookie Dec 9, 2021
snicoll pushed a commit that referenced this pull request Dec 9, 2021
This commit maps the `server.servlet.session.cookie.same-site`
configuration property to the `DefaultCookieSerializer` bean configured
in the Spring Session auto-configuration.

See gh-28784
@snicoll snicoll closed this in 770e509 Dec 9, 2021
@snicoll
Copy link
Member

snicoll commented Dec 9, 2021

Thanks again @vpavic

@vpavic vpavic deleted the gh-28772 branch December 9, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants