Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect link in kafka.adoc #30674

Closed
wants to merge 1 commit into from

Conversation

chanhyeong
Copy link
Contributor

I think the document about kafka might be moved from features to messaging, but there is still an old link.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 15, 2022
snicoll added a commit that referenced this pull request Apr 19, 2022
@snicoll
Copy link
Member

snicoll commented Apr 19, 2022

@chanhyeong tanks for the PR but I believe that the link is correct. The features at the beginning is an old artifact from a previous version but handled properly as we rewrite anchors.

Did you notice a version of the Spring Boot docs where the link isn't working? If that's the case, please share a link to it and we can investigate.

Irrespective of this, I don't think this change is correct.

@snicoll snicoll closed this Apr 19, 2022
@snicoll snicoll added status: declined A suggestion or change that we don't feel we should currently apply status: invalid An issue that we don't feel is valid and removed status: waiting-for-triage An issue we've not yet triaged status: declined A suggestion or change that we don't feel we should currently apply labels Apr 19, 2022
@chanhyeong
Copy link
Contributor Author

@snicoll

I think it will be fixed after deploying 4c5cb77.

I found this in current version (2.6.6). (https://docs.spring.io/spring-boot/docs/current/reference/html/index.html)
Currently, it works in single HTML page but doesn't work in messaging.
There are difference sentences too.

single HTML page

image

messaging

image

@snicoll snicoll reopened this Apr 19, 2022
@snicoll snicoll added type: documentation A documentation update and removed status: invalid An issue that we don't feel is valid labels Apr 19, 2022
@snicoll snicoll self-assigned this Apr 19, 2022
@snicoll snicoll added this to the 2.6.7 milestone Apr 19, 2022
@snicoll
Copy link
Member

snicoll commented Apr 19, 2022

@chanhyeong Sorry about that. I thought anchor rewrite was handling it, especially after having looked at the current doc. I looked for the single page version though. Going forward, please provide the link to the broken link please.

kafka is incorrect as I've mentioned but I'd like to give you the contribution. Thanks for getting back to us!

snicoll pushed a commit that referenced this pull request Apr 19, 2022
snicoll added a commit that referenced this pull request Apr 19, 2022
@snicoll snicoll closed this in 58eabc8 Apr 19, 2022
@snicoll
Copy link
Member

snicoll commented Apr 19, 2022

@chanhyeong thank you for making your first contribution to Spring Boot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants