Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App fails to start when it depends on thymeleaf-extras-springsecurity6 but does not have Spring Security on the classpath #31033

Closed
wants to merge 1 commit into from

Conversation

terminux
Copy link
Contributor

Spring Security dependency check for SpringSecurityDialect seems to be lost when restoring support for Thymeleaf, see 12cd97a. So I restored it and added some unit tests.

Related: #28967

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 14, 2022
@wilkinsona wilkinsona changed the title Restore Spring Security dependency check for SpringSecurityDialect App fails to start when it depends on thymeleaf-extras-springsecurity5 but does not have Spring Security on the classpath May 16, 2022
@wilkinsona wilkinsona added type: regression A regression from a previous release and removed status: waiting-for-triage An issue we've not yet triaged labels May 16, 2022
@wilkinsona wilkinsona added this to the 3.0.x milestone May 16, 2022
@wilkinsona wilkinsona self-assigned this May 18, 2022
@wilkinsona wilkinsona changed the title App fails to start when it depends on thymeleaf-extras-springsecurity5 but does not have Spring Security on the classpath App fails to start when it depends on thymeleaf-extras-springsecurity6 but does not have Spring Security on the classpath May 18, 2022
@wilkinsona wilkinsona modified the milestones: 3.0.x, 3.0.0-M3 May 18, 2022
@wilkinsona
Copy link
Member

Thanks very much, @terminux. I pulled the test side of this out into a separate issue so it could be tackled in our maintenance branches too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: regression A regression from a previous release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants