Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jar Handler never clears PROTOCOL_HANDLER system property #31870

Closed
wants to merge 1 commit into from
Closed

Jar Handler never clears PROTOCOL_HANDLER system property #31870

wants to merge 1 commit into from

Conversation

aoyvx
Copy link
Contributor

@aoyvx aoyvx commented Jul 26, 2022

fix #31838

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 26, 2022
@philwebb philwebb added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 26, 2022
@philwebb philwebb added this to the 2.6.x milestone Jul 26, 2022
@philwebb philwebb mentioned this pull request Jul 26, 2022
Closed
@philwebb philwebb changed the title The default value should not be set when get PROTOCOL_HANDLER. Jar Handler never clears PROTOCOL_HANDLER system property Jul 26, 2022
@philwebb philwebb changed the title Jar Handler never clears PROTOCOL_HANDLER system property The default value should not be set when get PROTOCOL_HANDLER. Jul 26, 2022
@philwebb philwebb changed the title The default value should not be set when get PROTOCOL_HANDLER. The default value should not be set when get PROTOCOL_HANDLER Jul 26, 2022
@philwebb philwebb changed the title The default value should not be set when get PROTOCOL_HANDLER Jar Handler never clears PROTOCOL_HANDLER system property Jul 26, 2022
@philwebb philwebb mentioned this pull request Jul 26, 2022
Closed
philwebb pushed a commit that referenced this pull request Jul 26, 2022
@aoyvx @philwebb
Ensure PROTOCOL_HANDLER system property is reset
8c93d2e 
See gh-31870
@philwebb philwebb closed this in 923dd35 Jul 26, 2022
@philwebb philwebb modified the milestones: 2.6.x, 2.6.11 Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
2.6.11
Development

Successfully merging this pull request may close these issues.

There seems to be a section of wrong logic in org.springframework.boot.loader.jar.Handler#captureJarContextUrl
3 participants
@aoyvx @philwebb @spring-projects-issues