Misleading error message when using JarMode Layertools and the source is not an archive #31997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split state assertions to output more explizit error message, if the source file is not an archive. This way it's easier to distinguish whether the file is not there of if it has not supported name suffix.
|
@nilshartmann Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@nilshartmann Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
changed the title
wilkinsona
added
type: bug
snicoll
pushed a commit
that referenced
this pull request
Aug 17, 2022
This commit split the existing assertion to provide an explicit error message if the source file is not an archive. See gh-31997
snicoll
added a commit
that referenced
this pull request
Aug 17, 2022
|
@nilshartmann thank you for making your first contribution to Spring Boot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the source file given to the layertools is not an archive file, the error message says that the file cannot be found. That might be confusing, if the file actually exists but "only" has the wrong suffix.
I think splitting the assertion into two separate ones gives more precise error messages.