Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caching to o.s.b.test.system.OutputCapture #32180

Closed

Conversation

An1s9n
Copy link
Contributor

@An1s9n An1s9n commented Aug 28, 2022

Dear team,

this pull request is my attempt to help with #32033 issue. After my modifications I tried to run test mentioned in the issue and execution has taken less than a second on my machine, so I suppose my pull request makes sense and eliminates the problem. I kindly ask you to review it and tell me what should be fixed.

Thank you in advance for your time!

@An1s9n An1s9n changed the title Add caching to org.springframework.boot.test.system.OutputCapture Add caching to o.s.b.test.system.OutputCapture Aug 28, 2022
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 28, 2022
@An1s9n An1s9n marked this pull request as draft August 28, 2022 06:21
@An1s9n An1s9n marked this pull request as ready for review August 28, 2022 11:30
@philwebb
Copy link
Member

philwebb commented Oct 4, 2022

Thanks very much for the pull-request @An1s9n. In the end I decided to go with a slightly different approach and use AtomicReference members to store the previous value. See commit e917bd0 for details.

Sorry this one didn't get merged but thanks for your efforts.

@philwebb philwebb closed this Oct 4, 2022
@philwebb philwebb added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants