Move property notes up to external configuration section #35662
Closed
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@twobiers Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@twobiers Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks for the suggestion, @twobiers. I agree that the section should move up. It looks like the section on JNDI properties should move up as well. Would you like to do that too as part of this PR? |
wilkinsona
added
type: documentation
wilkinsona
added
the
status: waiting-for-feedback
twobiers
changed the title
|
Oh yes, that makes sense. Did that aswell. |
spring-projects-issues
added
status: feedback-provided
|
Thanks! |
wilkinsona
approved these changes
May 30, 2023
scottfrederick
changed the title
mhalbritter
pushed a commit
that referenced
this pull request
Jun 7, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves the already present note about relaxed property binding which affects naming of environment variables upwards to a more appropriate position.
The reason for the change is that it's hard to find information about the relaxed binding if you're reading the externalized configuration paragraph. In my opinion, there's no reason to hide the note under a relatively unrelated paragraph and it should be mentioned straight at the same place where environment variables as a property source are being introduced. At least that's where I would search for such a note (e.g. If debugging why the binding doesn't work).