Add Spring Pulsar container property customizers #37559
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the ability for users to register property customizers for the auto-configured Spring Pulsar listener containers. See spring-projects#36347
spring-projects-issues
added
the
status: waiting-for-triage
onobc
commented
Sep 25, 2023
| * @since 3.2.0 | ||
| */ | ||
| @FunctionalInterface | ||
| public interface PulsarContainerPropertiesCustomizer { |
There was a problem hiding this comment.
I was originally going to put these container props customizers in the framework. However, the container factories do not need to accept a customizer as they already accept the container props. Non-boot users will already have to create the container props in order to create the container factory. They will therefore just adjust the props accordingly - no need to also have a customizer.
IOW - the framework does not need the concept of container props customizers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the ability for users to register property customizers for the auto-configured Spring Pulsar listener containers.
The motivation is to ultimately give users the ability to set the
AsyncTaskExecutorson the underlying listener containers to support Java virtual threads capability.See #36347