Error mark in the log message for PatternParseException is in the wrong place #38944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatternParseException.toDetailedString() return a String with a mark to specify the error position in the pattern. The mark takes place in the second line in the String returned. Because PatternParseFailureAnalyzer.analyze appended "Invalid mapping pattern detected:" at the beginning of the returned String, the mark was not well positioned. Now, a "\n" is inserted after "Invalid mapping pattern detected:" and the mark is well positioned
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: bug
wilkinsona
changed the title
mhalbritter
pushed a commit
that referenced
this pull request
Jan 10, 2024
PatternParseException.toDetailedString() return a String with a mark to specify the error position in the pattern. The mark takes place in the second line in the String returned. Because PatternParseFailureAnalyzer.analyze appended "Invalid mapping pattern detected:" at the beginning of the returned String, the mark was not well positioned. Now, a "\n" is inserted after "Invalid mapping pattern detected:" and the mark is well positioned See gh-38944
mhalbritter
added a commit
that referenced
this pull request
Jan 10, 2024
|
Thank you very much and congratulations on your first contribution 🎉! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a PatternParseException for a regexp path pattern occurs in a Spring MVC application launched by Spring Boot, the PatternParseFailureAnalyzer logs a message like this in console :
At line 4, the mark '^' which indicates the error in the pattern is misplaced because the string returned by PatternParseException.toDetailedString() is appended to "Invalid mapping pattern detected:".
So this PR proposes to insert a "\n" after "Invalid mapping pattern detected:" . The error mark will be well positioned like this :
The only change in the main code is th addition of "\n". The rest of the changes adapts the test PatternParseFailureAnalyzerTests.
NB : I was not able to run the
./gradlew checkfor the whole project (8 tests failed for Task :buildSrc:test) but I ran tests for the module spring-boot-project/spring-boot and the number of failling tests is the same after the change