Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add String to CronExpression conversion support #39304

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amiriahmad72
Copy link

@amiriahmad72 amiriahmad72 commented Jan 25, 2024

Add String to CronExpression conversion support.

This converter use CronExpression parse () method to convert String to CronExpression.

For example, it helps us to use type-safe CronExpression in ConfigurationProperties classes.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 25, 2024
@wilkinsona
Copy link
Member

Thanks for the suggestion. Given that CronExpression is a Spring Framework type, I wonder if the should be added to Spring Framework rather than to Spring Boot. I'll discuss it with the Framework team.

@wilkinsona
Copy link
Member

@amiriahmad72 it would also be useful to know how you're using CronExpression. There's very little, if any, API in Spring Framework that uses it. For example, CronTrigger takes a String rather than a pre-parsed CronExpression instance. It's not yet clear to me how having such conversion support would be generally useful.

@wilkinsona wilkinsona added the status: waiting-for-feedback We need additional information before we can continue label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants