Add OAuth2-Client ConnectionDetails and Keycloak Docker-Compose support #39391
+825
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
for: team-meeting
|
Any opinions on this @philwebb , @mhalbritter? 😀 |
|
We're currently preparing the Spring Boot 3.3 release. This PR is planned as an enhancement for 3.4 and we'll look into it in detail when 3.3 is out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36777
This PR includes:
Registration+ProviderOpen Questions:
Since the
Registrationhas a lot fields that cant simply be extracted from any Keycloak env. variables, I added Docker service labels to set e.g. thescopeof the client, or the client secret. Is this the best way to handle this?I also thought about not ignoring the
PropertiesOAuth2ClientConnectionDetailsif the Docker-Compose support already created anOAuth2ClientConnectionDetailsBean, but rather merge them together, so that the registration-id, provider are extracted from the Keycloak env. variables and the other settings (scope,client-secret, etc.) could be set in theapplication.properties. I am not sure which to prefer.When the open questions are answered, I would also add the TestContainer-Support for Keycloak.